[PATCH 1/3 v2][MTD] P4080/eLBC: Make Freescale elbc interrupt common to elbc devices

[Zang Roy-R61911]

> -----Original Message-----
> From: Anton Vorontsov [mailto:cbouatmailru at gmail.com]
> Sent: Thursday, September 09, 2010 19:54 PM
> To: Zang Roy-R61911
> Cc: linux-mtd at lists.infradead.org; dwmw2 at infradead.org; dedekind1 at gmail.com;
> akpm at linux-foundation.org; Lan Chunhe-B25806; Wood Scott-B07421; Gala Kumar-
> B11780; linuxppc-dev at ozlabs.org
> Subject: Re: [PATCH 1/3 v2][MTD] P4080/eLBC: Make Freescale elbc interrupt
> common to elbc devices
> 
> Just a few cosmetic nits for this patch...
> 
> On Thu, Sep 09, 2010 at 06:20:30PM +0800, Roy Zang wrote:
> [...]
[snip]
> > +static const struct of_device_id fsl_lbc_match[] = {
> > +	{ .compatible = "fsl,elbc", },
> > +	{ .compatible = "fsl,pq3-localbus", },
> > +	{ .compatible = "fsl,pq2-localbus", },
> > +	{ .compatible = "fsl,pq2pro-localbus", },
> > +	{},
> > +};
> 
> You need linux/mod_devicetable.h for this.
It has been include in linux/of.h.

> 
> > +
> > +static struct of_platform_driver fsl_lbc_ctrl_driver = {
> 
> Need linux/of_platform.h for this.
It has been include by
fsl_lbc.h->linux/of_platform.h-> linux/platform_device.h
Before submitting the patch, I have built and tested it.

Do you think I do not build the tree before I send out the patch?
> 
> > +
> > +static struct of_platform_driver fsl_lbc_ctrl_driver = {
> 
> Need linux/of_platform.h for this.
> 
> But you actually don't need of_platform_driver, as for the
> new code you can use platform_driver (and thus
> linux/platform_device.h).
I'd prefer using of_platform_driver here for simplified code.
Any special reason to use platform_device here?
Thanks.
Roy