Small issue at init with spi_mpc8xxx.c with CPM1

LEROY Christophe christophe.leroy at c-s.fr
Tue Sep 7 19:17:17 EST 2010


  Dear Kumar,

I have a small issue in the init of spi_mpc8xxx.c with MPC866 (CPM1)

Unlike cpm_uart that maps the parameter ram directly using 
of_iomap(np,1), spi_mpc8xxx.c uses cpm_muram_alloc_fixed().

This has two impacts in the .dts file:
* The driver must be declared with pram at 1d80 instead of 3d80 whereas 
it is not a child of muram at 2000 but a child of cpm at 9c0
* muram at 2000/data at 0 must be declared with reg = <0x0 0x2000>   whereas 
is should be reg=<0x0 0x1c00> to avoid cpm_muram_alloc() to allocate 
space from parameters ram.

Maybe I misunderstood something ?

Regards
Christophe Leroy


More information about the Linuxppc-dev mailing list