[PATCH 4/8] drivers/i2c/busses/i2c-pasemi.c: Fix unsigned return type

Olof Johansson olof at lixom.net
Tue Sep 7 02:30:44 EST 2010


On Sun, Sep 05, 2010 at 09:00:22PM +0200, Julia Lawall wrote:
> The function has an unsigned return type, but returns a negative constant
> to indicate an error condition.  The result of calling the function is
> always stored in a variable of type (signed) int, and thus unsigned can be
> dropped from the return type.
> 
> A sematic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @exists@
> identifier f;
> constant C;
> @@
> 
>  unsigned f(...)
>  { <+...
> *  return -C;
>  ...+> }
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia at diku.dk>

Acked-by: Olof Johansson <olof at lixom.net>



More information about the Linuxppc-dev mailing list