[PATCH 2/3][MTD] P4080/nand: Only make elbc nand driver detect nand flash partitions

Scott Wood scottwood at freescale.com
Sat Sep 4 03:33:38 EST 2010

On Fri, 3 Sep 2010 15:43:57 +0400
Anton Vorontsov <cbouatmailru at gmail.com> wrote:

> On Fri, Aug 06, 2010 at 10:51:35AM +0800, Roy Zang wrote:
> [...]
> >  
> > +static struct fsl_elbc_fcm_ctrl *elbc_fcm_ctrl;
> > +
> Are you sure that you want it as a global var? A bit scary change.
> Oh, you probably don't need it, as you can get it from
> fsl_lbc_ctrl_dev->nand?
> I wonder if Scott saw these patches? Cc'ed.

I saw many iterations of these patches. :-)

I had the same reaction to this, but during internal review it did not
seem to be the most pressing concern to focus on.

In practice, there will only be one eLBC, and properly handling multiple
devices and binding the right one across this new boundary would have
been unnecessary complexity.


More information about the Linuxppc-dev mailing list