ERR_PTR pattern in phylib
Maciej W. Rozycki
macro at linux-mips.org
Fri Sep 3 02:43:35 EST 2010
On Thu, 2 Sep 2010, David Miller wrote:
> > Arguably using a union here would make things cleaner and any reasonable
> > ABI will place small unions used as arguments or return values in
> > registers, but I'm not sure if the cost of the rewrite is worth the
>
> Well, sparc 32-bit's ABI for one is "not reasonable" and these return
> values will always get stack slots and passed back by reference.
So that makes it two -- together with MIPS o32. ;) Still used by
everybody concerned as contraptions tend to stick. :/ That doesn't make
it reasonable though. Nor me to push the union approach -- that's an
elegant approach that would probably give us less than take in return.
Maciej
More information about the Linuxppc-dev
mailing list