ERR_PTR pattern in phylib
afleming at freescale.com
Thu Sep 2 01:50:33 EST 2010
On Sep 1, 2010, at 9:43, Grant Likely <grant.likely at secretlab.ca> wrote:
> In the interest of making driver code easier to write and review,
> would you be opposed to a set of patches to remove the ERR_PTR()
> pattern from phylib and its users?
Not at all. I was trying to make sure all the information was available, and I'm not really a big fan of passing in a **ptr to get set. But I don't really have a strong opinion. This is just the design i settled on. Heck, 99.9% of the errors are unlikely to ever happen, a they're caused by hardware malfunction!
> Grant Likely, B.Sc., P.Eng.
> Secret Lab Technologies Ltd.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Linuxppc-dev