question about arch/powerpc/platforms/cell/celleb_scc_uhc.c

[Joe Perches]

On Wed, 2010-09-01 at 17:51 +0200, Julia Lawall wrote:
> The file arch/powerpc/platforms/cell/celleb_scc_uhc.c contains the 
> following function:
> static inline int uhc_clkctrl_ready(u32 val)
> {
>         const u32 mask = SCC_UHC_USBCEN | SCC_UHC_USBCEN;
>         return((val & mask) == mask);
> }
> The variable mask is a bit or of two identical constants.  Later in the 
> same file in the function enable_scc_uhc, I see the code:
> val |= (SCC_UHC_USBCEN | SCC_UHC_USBEN);
> Should the code in uhc_clkctrl_ready also be SCC_UHC_USBCEN | SCC_UHC_USBEN?
> Or something else?

Thanks Julia.

This was also noticed a couple of years ago and not applied
http://lkml.indiana.edu/hypermail/linux/kernel/0808.2/1428.html

One day...