[PATCH] powerpc/512x: fix clk_get() return value

Grant Likely grant.likely at secretlab.ca
Thu Sep 2 01:32:39 EST 2010


On Tue, Aug 31, 2010 at 05:43:51PM +0900, Akinobu Mita wrote:
> clk_get() should return an ERR_PTR value on error, not NULL.
> 
> Signed-off-by: Akinobu Mita <akinobu.mita at gmail.com>
> Cc: Grant Likely <grant.likely at secretlab.ca>
> Cc: linuxppc-dev at lists.ozlabs.org

applied, thanks.

g.

> ---
>  arch/powerpc/platforms/512x/clock.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/512x/clock.c b/arch/powerpc/platforms/512x/clock.c
> index 5b243bd..3dc2a8d 100644
> --- a/arch/powerpc/platforms/512x/clock.c
> +++ b/arch/powerpc/platforms/512x/clock.c
> @@ -57,7 +57,7 @@ static struct clk *mpc5121_clk_get(struct device *dev, const char *id)
>  	int id_match = 0;
>  
>  	if (dev == NULL || id == NULL)
> -		return NULL;
> +		return clk;
>  
>  	mutex_lock(&clocks_mutex);
>  	list_for_each_entry(p, &clocks, node) {
> -- 
> 1.7.1.231.gd0b16
> 


More information about the Linuxppc-dev mailing list