ERR_PTR pattern in phylib
davem at davemloft.net
Thu Sep 2 01:27:29 EST 2010
From: Grant Likely <grant.likely at secretlab.ca>
Date: Wed, 1 Sep 2010 08:42:49 -0600
> It seems to me that phylib is one of the cases where the users (the
> network drivers) don't actually care about the specific error code
> when calling phylib functions. The drivers only seem to care whether
> or not the function failed, and if it did then bail out. I've also
> noticed that using the "if (!ptr)" test on phylib return values is a
> common error for driver writers.
> In the interest of making driver code easier to write and review,
> would you be opposed to a set of patches to remove the ERR_PTR()
> pattern from phylib and its users?
I'm opposed to it because it means that if code actually does
care about the error code it will no longer be able to obtain
Please don't make this change, thanks.
More information about the Linuxppc-dev