[PATCH v2 1/4] fsl_rio: fix compile errors

Li Yang-R58472 r58472 at freescale.com
Wed Sep 1 17:43:22 EST 2010

>Subject: Re: [PATCH v2 1/4] fsl_rio: fix compile errors
>On Aug 31, 2010, at 10:40 PM, Li Yang wrote:
>> On Wed, Sep 1, 2010 at 5:39 AM, Kumar Gala <galak at kernel.crashing.org>
>>> On Jun 18, 2010, at 1:24 AM, Li Yang wrote:
>>>> Fixes the following compile problem on E500 platforms:
>>>> arch/powerpc/sysdev/fsl_rio.c: In function 'fsl_rio_mcheck_exception':
>>>> arch/powerpc/sysdev/fsl_rio.c:248: error: 'MCSR_MASK' undeclared
>(first use in this function)
>>>> Also fixes the compile problem on non-E500 platforms.
>>>> Signed-off-by: Li Yang <leoli at freescale.com>
>>>> ---
>>>> arch/powerpc/sysdev/fsl_rio.c |    6 +++++-
>>>> 1 files changed, 5 insertions(+), 1 deletions(-)
>>> applied to merge
>> Thanks, Kumar.
>> How about the other ones in the series?
>I want to rework how the whole RIO mcheck works and will do so for 2.6.37.
>Part of the problem I have is that we are ignoring the fact that this code
>isn't right for 8641 support of SRIO.

Right.  So I protected the code with #ifdef CONFIG_E500.  The following patches in series enable it to be used by e500mc.  Having it to support all platforms is surely the best, but before that we can make it better.  And I believe they wouldn't get in the way of further MPC8641 support.

- Leo

More information about the Linuxppc-dev mailing list