[PATCH 2/3] PPC: Fix compilation of fsl_rio.c

Kumar Gala galak at kernel.crashing.org
Wed Sep 1 04:55:38 EST 2010

On Aug 31, 2010, at 1:10 PM, Scott Wood wrote:

> On Tue, 31 Aug 2010 04:15:21 +0200
> Alexander Graf <agraf at suse.de> wrote:
>> Commit a52c8f52 introduced machine check magic for the RapidIO chip.
>> Unfortunately it was so magical that it used constants that aren't even
>> defined!
>> This patch bluntly comments out the broken constant's usage. This
>> probably means that said functionality thus doesn't work, but at
>> least it makes it compile for me.
> The MCSR_MASK is actually completely unnecessary -- it doesn't change
> the result of testing bits that are within the mask.
> Multiple patches have been posted for this already, including:
> http://patchwork.ozlabs.org/patch/56135/
> Someone just needs to apply it. :-)

I've got a different version as I don't want to override the mcheck handler.

- k

More information about the Linuxppc-dev mailing list