[PATCH v3 2/7] spi/mpc8xxx: refactor the common code for SPI/eSPI controller

Hu Mingkai-B21284 B21284 at freescale.com
Fri Oct 8 17:37:00 EST 2010



> -----Original Message-----
> From: Anton Vorontsov [mailto:cbouatmailru at gmail.com]
> Sent: Friday, October 01, 2010 7:22 PM
> To: Hu Mingkai-B21284
> Cc: linuxppc-dev at ozlabs.org; spi-devel-general at lists.sourceforge.net; linux-
> mtd at lists.infradead.org; Gala Kumar-B11780; Zang Roy-R61911
> Subject: Re: [PATCH v3 2/7] spi/mpc8xxx: refactor the common code for SPI/eSPI
> controller
> 
> On Thu, Sep 30, 2010 at 04:00:41PM +0800, Mingkai Hu wrote:
> [...]
> > -static void mpc8xxx_spi_change_mode(struct spi_device *spi)
> > +static void fsl_spi_change_mode(struct spi_device *spi)
> >  {
> >  	struct mpc8xxx_spi *mspi = spi_master_get_devdata(spi->master);
> >  	struct spi_mpc8xxx_cs *cs = spi->controller_state;
> > -	__be32 __iomem *mode = &mspi->base->mode;
> > +	struct fsl_spi_reg *reg_base = (struct fsl_spi_reg *)mspi->reg_base;
> 
> No need for these type casts (the same is for the whole patch).
> 

Fix it.

Thanks,
Mingkai


More information about the Linuxppc-dev mailing list