[PATCH v3 6/7] mtd: m25p80: add a read function to read page by page

Hu Mingkai-B21284 B21284 at freescale.com
Fri Oct 8 13:15:26 EST 2010



> -----Original Message-----
> From: Anton Vorontsov [mailto:cbouatmailru at gmail.com]
> Sent: Thursday, September 30, 2010 11:07 PM
> To: Grant Likely
> Cc: David Brownell; linuxppc-dev at ozlabs.org; Hu Mingkai-B21284; linux-
> mtd at lists.infradead.org; Gala Kumar-B11780; spi-devel-
> general at lists.sourceforge.net
> Subject: Re: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by
> page
> 
> On Thu, Sep 30, 2010 at 11:41:40PM +0900, Grant Likely wrote:
> > On Thu, Sep 30, 2010 at 11:16 PM, Grant Likely
> > <grant.likely at secretlab.ca> wrote:
> > > On Thu, Sep 30, 2010 at 7:46 PM, David Brownell <david-b at pacbell.net> wrote:
> > >>
> > >> --- On Thu, 9/30/10, Mingkai Hu <Mingkai.hu at freescale.com> wrote:
> > >>
> > >>> From: Mingkai Hu <Mingkai.hu at freescale.com>
> > >>> Subject: [PATCH v3 6/7] mtd: m25p80: add a read function to read
> > >>> page by page
> > >>
> > >> NAK.
> > >>
> > >> We went over this before.
> > >
> > > Yes, I agree with David on this.  If large transfers don't work,
> > > then it is the SPI master driver that is buggy.
> >
> > By the way, does this fix your problem?
> >
> > https://patchwork.kernel.org/patch/184752/
> 
> It shouldn't. AFAIK, eSPI is PIO-only controller, and the overrun fix is for the
> DMA mode.
> 
> Thanks,
> 
> p.s. Btw, in patch 3/7, is_dma_mapped argument of fsl_espi_bufs() is unneeded.
> 

Yes, the is_dma_mapped isn't needed, I'll remove it.

Thanks,
Mingkai


More information about the Linuxppc-dev mailing list