linux-next: build warning in Linus' tree

[Arnaud Lacombe]

Hi,

On Wed, Nov 17, 2010 at 10:55 PM, Benjamin Herrenschmidt
<benh at kernel.crashing.org> wrote:
> On Mon, 2010-10-25 at 17:03 +1100, Stephen Rothwell wrote:
>> Hi Arnaud,
>>
>> On Sun, 24 Oct 2010 23:47:09 -0400 Arnaud Lacombe <lacombar at gmail.com> wrote:
>> >
>> > The following patch should fix this warning.
>>
>> I think the following is preferable.  Not tested yet, I will test
>> tomorrow and submit properly then.
>
> I agree. Tho I don't understand the original problem. Both definitions
> have no parenthesis for me and I don't see warnings, or am I missing
> some changes still in -next that cause this ?
>
The warning was caused by part of the following commit which came
through the x86 tree, afaik during the merge window:

       commit 3234282f33b29d349bcada40204fc7c8fda7fe72
       Author: Jan Beulich <JBeulich at novell.com>
       Date:   Tue Oct 19 14:52:26 2010 +0100
       x86, asm: Fix CFI macro invocations to deal with shortcomings in gas

It looks to have been fixed by:

commit 95a2f6f72d37762ba1b3d6c8031f66a6467a63df
Author: David Howells <dhowells at redhat.com>
Date:   Wed Oct 27 17:28:32 2010 +0100

    Partially revert patch that encloses asm-offset.h numbers in brackets

    Partially revert patch:

        commit 3234282f33b29d349bcada40204fc7c8fda7fe72
        Author: Jan Beulich <JBeulich at novell.com>
        Date:   Tue Oct 19 14:52:26 2010 +0100
        x86, asm: Fix CFI macro invocations to deal with shortcomings in gas
[...]

which came in through the mn10300 tree. So if you're no longer seeing
the warning, no ppc specific patch seems to be needed.

 - Arnaud