[PATCH][v3] fsl_rio: move machine_check handler into machine_check_e500 & machine_check_e500mc

[Xie Shaohui-B21989]

> -----Original Message-----
> From: Bounine, Alexandre [mailto:Alexandre.Bounine at idt.com]
> Sent: Saturday, November 13, 2010 12:30 AM
> To: Xie Shaohui-B21989; linuxppc-dev at lists.ozlabs.org
> Cc: akpm at linux-foundation.org; Li Yang-R58472; Gala Kumar-B11780; Zang
> Roy-R61911
> Subject: RE: [PATCH][v3] fsl_rio: move machine_check handler into
> machine_check_e500 & machine_check_e500mc
> 
> > int machine_check_e500mc(struct pt_regs *regs)  int
> > machine_check_e500(struct pt_regs *regs)  {
> >  	unsigned long reason = get_mc_reason(regs);
> > +	int ret = 0;
> > +
> > +	if (reason & MCSR_BUS_RBERR) {
> > +		ret = fsl_rio_mcheck_exception(regs);
> > +		if (ret == 1)
> > +			return ret;
> > +	}
> 
> Do we really need 'ret' variable here?
> There is no further use of it by the rest of the code.
> Maybe just return 1 here if fsl_rio_mcheck_exception() returns 1 ?
> 
> >

Ok, I'll remove the ret, do you have any comment for the error handler
patch?
http://patchwork.ozlabs.org/patch/69962/


Thanks & Best Regards,
Shaohui