[PATCH 3/4][v2] fsl_rio: move machine_check handler into machine_check_e500 & machine_check_e500mc
Bounine, Alexandre
Alexandre.Bounine at idt.com
Fri Nov 12 01:29:01 EST 2010
Kumar Gala <kumar.gala at freescale.com> wrote:
> > @@ -527,8 +535,12 @@ int machine_check_e500(struct pt_regs *regs)
>
> To deal w/Alex's comment do:
>
> machine_check_e500(...) {
>
> int ret = 0;
>
>
> > printk("Bus - Write Address Error\n");
> > if (reason & MCSR_BUS_IBERR)
> > printk("Bus - Instruction Data Error\n");
> > - if (reason & MCSR_BUS_RBERR)
> > + if (reason & MCSR_BUS_RBERR) {
> > printk("Bus - Read Data Bus Error\n");
> > +#ifdef CONFIG_RAPIDIO
> > + fsl_rio_mcheck_exception(regs);
> > +#endif
>
> make this like 'ret = fsl_rio...
>
Please, place it in the beginning of the machine_check_e500[mc](...) as
well to avoid any 'printk' if RIO exception was handled properly.
Alex.
More information about the Linuxppc-dev
mailing list