[PATHC v1] PPC4xx: Adding PCI(E) MSI support

Josh Boyer jwboyer at linux.vnet.ibm.com
Wed Nov 3 23:48:40 EST 2010


On Wed, Nov 03, 2010 at 11:11:33PM +1100, Michael Ellerman wrote:
>> +	struct device_node *msi_dev = NULL;
>> +	const u32 *count;
>> +
>> +	msi_dev = of_find_node_by_name(NULL, "ppc4xx-msi");
>> +	if (msi_dev)
>> +		return -ENODEV;
>> +

You also leak a reference to the node here, as there is never a call to
of_node_put.

josh


More information about the Linuxppc-dev mailing list