[PATCH] iSeries: Don't leak if allocations fail in mf_getSrcHistory

Stephen Rothwell sfr at canb.auug.org.au
Tue Nov 2 07:10:25 EST 2010

Hi Jesper,

On Mon, 01 Nov 2010 22:10:42 +1100 Michael Ellerman <michael at ellerman.id.au> wrote:
> On Sat, 2010-10-30 at 19:20 +0200, Jesper Juhl wrote:
> > 
> > If memory is tight and a dynamic allocation fails there's no reason to 
> > make a bad situation worse by leaking memory.
> > 
> > mf_getSrcHistory potentially leaks pages[0-3]. I believe the right thing 
> > to do is to free that memory again before returning -ENOMEM - which is 
> > what this patch does.
> > 
> > I realize that the function is under '#if 0' so this probably doesn't 
> > matter much, but I assume that the function is still there for a reason 
> > (but I could be wrong, I don't know the powerpc code).
> > Anyway, I suggest we remove the leak.
> Stephen is the iSeries maintainer, and I think he #if 0'ed the code. But
> I don't think it will ever be un-ifdef'ed, so should probably just be
> removed.

Well, only unofficially iseries maintainer :-)

Yes, just remove the whole function ... it was never used and never will

Stephen Rothwell                    sfr at canb.auug.org.au
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20101102/f60ef595/attachment.pgp>

More information about the Linuxppc-dev mailing list