[PATCH 1/3] powerpc: kdump: Fix NULL pointer dereference in irq disable code

[Michael Ellerman]

On Tue, 2010-05-11 at 12:23 +1000, Anton Blanchard wrote:
> With sparse irqs we have to check if we have a descriptor before dereferencing
> it.
> 
> Signed-off-by: Anton Blanchard <anton at samba.org>
> ---
> 
> diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c
> index 6f4613d..5182439 100644
> --- a/arch/powerpc/kernel/crash.c
> +++ b/arch/powerpc/kernel/crash.c
> @@ -375,6 +375,9 @@ void default_machine_crash_shutdown(struct pt_regs *regs)
>  	for_each_irq(i) {
>  		struct irq_desc *desc = irq_to_desc(i);
>  
> +		if (!desc)
> +			continue;
> +
>  		if (desc->status & IRQ_INPROGRESS)
>  			desc->chip->eoi(i);
>  

Ouch, my bad.

cheers
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20100511/7323c3c9/attachment.pgp>