question about drivers/macintosh/windfarm_pm91.c
Benjamin Herrenschmidt
benh at kernel.crashing.org
Mon Mar 29 08:08:59 EST 2010
On Sun, 2010-03-28 at 17:48 +0200, Julia Lawall wrote:
> The function wf_smu_remove in the file drivers/macintosh/windfarm_pm91.c
> ends with the following code:
>
> if (wf_smu_slots_fans)
> kfree(wf_smu_cpu_fans);
> if (wf_smu_drive_fans)
> kfree(wf_smu_cpu_fans);
> if (wf_smu_cpu_fans)
> kfree(wf_smu_cpu_fans);
>
> This looks quite strange. Is it supposed to be if (x) kfree(x); in each
> case?
Definitely a typo. In fact, the if () aren't even necessary. Patch
welcome :-)
Cheers,
Ben.
More information about the Linuxppc-dev
mailing list