[PATCH 4/7] hvc_console: Fix race between hvc_close and hvc_remove
Anton Blanchard
anton at samba.org
Fri Mar 26 10:30:31 EST 2010
Hi,
> And this suggests that hvc_kick() is called before hvc_task is
> initialised, ie, before hvc_init() is called.
>
> Does this help?
Looks good, tests OK on my POWER5 box. Thanks!
Tested-by: Anton Blanchard <anton at samba.org>
> diff --git a/drivers/char/hvc_console.c b/drivers/char/hvc_console.c
> index ba55bba..50ac983 100644
> --- a/drivers/char/hvc_console.c
> +++ b/drivers/char/hvc_console.c
> @@ -285,6 +285,9 @@ EXPORT_SYMBOL_GPL(hvc_instantiate);
> /* Wake the sleeping khvcd */
> void hvc_kick(void)
> {
> + if (!hvc_task)
> + return;
> +
> hvc_kicked = 1;
> wake_up_process(hvc_task);
> }
>
> Amit
More information about the Linuxppc-dev
mailing list