Virtio_console usage of early printk

[François Diakhate]

On Tue, Mar 23, 2010 at 9:55 AM, Amit Shah <amit.shah at redhat.com> wrote:
> On (Mon) Mar 22 2010 [18:45:47], François Diakhate wrote:
>> Hi all,
>>
>> As far as I can see, early_put_chars is not used by virtio_console
>> because it checks whether there is a port available before using it.
>> If I understand correctly, this makes it useless because once we have
>> a port, we can use the regular virtio transport to output things to
>> the console. Does the attached patch seem valid ? Feedback from s390
>> and powerpc users who use this functionality would be appreciated.
>>
>> Thanks,
>> François
>
>> From 3961f380bbe84a1036ddfc823039cbee31b44dcb Mon Sep 17 00:00:00 2001
>> From: =?utf-8?q?Fran=C3=A7ois=20Diakhat=C3=A9?= <fdiakh at gmail.com>
>> Date: Thu, 18 Mar 2010 14:48:20 +0100
>> Subject: virtio: console: Fix early_put_chars usage
>>
>> Currently early_put_chars is not used by virtio_console because it can only be used once a port has been found, at which point it's too late because it is no longer needed. This patch should fix it.
>
> You'll have to give a signed-off-by for the patch.
>
>                Amit
>

Sorry, I didn't have access to my computer this morning. Here is the
patch with a sign-off, if you still need it.

François
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-virtio-console-Fix-early_put_chars-usage.patch
Type: text/x-patch
Size: 1264 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20100323/738de479/attachment-0001.bin>