[Patch 1/1] PPC64-HWBKPT: Implement hw-breakpoints for PPC64
K.Prasad
prasad at linux.vnet.ibm.com
Tue Mar 23 18:28:54 EST 2010
On Tue, Mar 23, 2010 at 04:33:01PM +1100, Paul Mackerras wrote:
> On Mon, Mar 08, 2010 at 11:44:48PM +0530, K.Prasad wrote:
>
> > @@ -479,6 +483,7 @@ struct task_struct *__switch_to(struct t
> > old_thread->accum_tb += (current_tb - start_tb);
> > new_thread->start_tb = current_tb;
> > }
> > + flush_ptrace_hw_breakpoint(current);
> > #endif
> >
> > local_irq_save(flags);
>
> This line should be in flush_thread(), not __switch_to(). In fact it
> may not be necessary at all given that flush_ptrace_hw_breakpoint()
> gets called in do_exit().
>
> Paul.
Yes, I did realise it. The unintended movement of
flush_ptrace_hw_breakpoint() from flush_thread() is a result of a
patching error (while forward porting).
A fix for this issue along with those pointed out by BenH will be a part
of the next version of the patch, that I intend to send very soon.
Thanks for reviewing them.
-- K.Prasad
More information about the Linuxppc-dev
mailing list