[PATCH] powerpc/fsl: Add multiple MSI bank support

Timur Tabi timur at freescale.com
Mon Mar 22 13:31:06 EST 2010


On Thu, Mar 18, 2010 at 9:53 AM, Kumar Gala <galak at kernel.crashing.org> wrote:
> +       /* The multiple setting ppc_md.setup_msi_irqs will not harm things */
> +       if (!ppc_md.setup_msi_irqs) {
> +               ppc_md.setup_msi_irqs = fsl_setup_msi_irqs;
> +               ppc_md.teardown_msi_irqs = fsl_teardown_msi_irqs;
> +               ppc_md.msi_check_device = fsl_msi_check_device;
> +       } else if (ppc_md.setup_msi_irqs != fsl_setup_msi_irqs) {
> +               dev_err(&dev->dev, "Different MSI driver already installed!\n");
> +               err = -EBUSY; /* or some other error code */

The comment is inappropriate.  I put it there as a reminder that maybe
EBUSY is not the best choice.  But if it is, then the comment should
be removed.

-- 
Timur Tabi
Linux kernel developer at Freescale


More information about the Linuxppc-dev mailing list