[PATCH] Macintosh: fix brace and trailing statement coding style issues in adb-iop.c This is a patch to the adb-iop.c file that cleans up brace and trailing statement warnings found by the checkpatch.pl tool. Signed-off-by: Michael Beardsworth <m

[Geert Uytterhoeven]

On Sun, Mar 21, 2010 at 10:16,  <fthain at telegraphics.com.au> wrote:
>> On Tue, Mar 09, 2010 at 01:46:20PM -0800, Michael Beardsworth wrote:
>> >...
>> >
>> >  #ifdef DEBUG_ADB_IOP
>> > -   printk("adb_iop_listen %p: rcvd packet, %d bytes: %02X %02X", req,
>> > -           (uint) amsg->count + 2, (uint) amsg->flags, (uint) amsg->cmd);
>> > +   printk(KERN_WARNING "adb_iop_listen %p: rcvd packet, %d bytes: %02X %02X",
>> > +           req, (uint) amsg->count + 2, (uint) amsg->flags, (uint) amsg->cmd);
>> >     for (i = 0; i < amsg->count; i++)
>> >             printk(" %02X", (uint) amsg->data[i]);
>> >     printk("\n");
>
>> >...
>> >  #ifdef DEBUG_ADB_IOP
>> > -   printk("adb_iop_start %p: sending packet, %d bytes:", req, req->nbytes);
>> > +   printk(KERN_WARNING "adb_iop_start %p: sending packet, %d bytes:", req, req->nbytes);
>> >     for (i = 0 ; i < req->nbytes ; i++)
>> >             printk(" %02X", (uint) req->data[i]);
>> >     printk("\n");
>
> KERN_DEBUG is used for debugging messages, not KERN_WARNING.

And that change is not covered by the patch description.

BTW, pr_debug(), these days.

>  int adb_iop_init(void)
>  {
> -       printk("adb: IOP ISM driver v0.4 for Unified ADB.\n");
> +       printk(KERN_MESSAGE "adb: IOP ISM driver v0.4 for Unified ADB.\n");
>        iop_listen(ADB_IOP, ADB_CHAN, adb_iop_listen, "ADB");
>       return 0;
> }

Not to mention the non-existence of KERN_MESSAGE?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds