[PATCH]: Minor quibble in macintosh/windfarm_pm81.c

d binderman dcb314 at hotmail.com
Fri Mar 19 20:01:42 EST 2010



Hello there,

I just ran the sourceforge tool cppcheck over the source code of the
new Linux kernel 2.6.34-rc1

It said

[./macintosh/windfarm_pm81.c:760]: (style) Redundant condition. It is safe to deallocate a NULL poin
ter
[./macintosh/windfarm_pm81.c:762]: (style) Redundant condition. It is safe to deallocate a NULL poin
ter

The source code is

        /* Destroy control loops state structures */
        if (wf_smu_sys_fans)
                kfree(wf_smu_sys_fans);
        if (wf_smu_cpu_fans)
                kfree(wf_smu_cpu_fans);

Proposed patch file attached.

Regards

David Binderman

 		 	   		  
_________________________________________________________________
Send us your Hotmail stories and be featured in our newsletter
http://clk.atdmt.com/UKM/go/195013117/direct/01/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug39.patch
Type: text/x-patch
Size: 504 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20100319/6171d2cc/attachment.bin>


More information about the Linuxppc-dev mailing list