[PATCH] kvm/ppc: fix build warning

Alexander Graf agraf at suse.de
Fri Jun 25 19:21:14 EST 2010


On 25.06.2010, at 11:02, Denis Kirjanov wrote:

> On 06/25/2010 12:42 AM, Alexander Graf wrote:
>> 
>> On 24.06.2010, at 21:44, Denis Kirjanov wrote:
>> 
>>> Fix build warning:
>>> arch/powerpc/kvm/book3s_64_mmu.c: In function 'kvmppc_mmu_book3s_64_esid_to_vsid':
>>> arch/powerpc/kvm/book3s_64_mmu.c:446: warning: 'slb' may be used uninitialized in this function
>>> Signed-off-by: Denis Kirjanov<dkirjanov at kernel.org>
>> 
>> Are you sure this isn't a broken compiler? I don't see where it could be used uninitialized.
> 
> I'm using gcc version 4.3.4 (Gentoo 4.3.4 p1.1, pie-10.1.5)
> slb pointer initialized inside conditional branch
> and used later in the case case MSR_DR|MSR_IR
> 

Oh, I'm apparently looking at completely different code. The same function in git://git.kernel.org/pub/scm/virt/kvm/kvm.git is good. Which tree did you use?


Alex



More information about the Linuxppc-dev mailing list