[PATCH 1/2] powerpc/5200: Export port-config

Grant Likely grant.likely at secretlab.ca
Fri Jun 11 08:11:21 EST 2010


On Tue, Jun 8, 2010 at 10:46 AM, Eric Millbrandt
<emillbrandt at dekaresearch.com> wrote:
> Allow device drivers to safely modify port-config.  This allows device drivers
> access to gpio pins to manually bit-bang slave devices.
>
> Signed-off-by: Eric Millbrandt <emillbrandt at dekaresearch.com>

Unfortunately, still too much exposure of port-config to drivers for
my liking.  I'd be happier with an API that requests the mode for a
specific pin group instead of directly masking & setting bits....

but of course I've also just said in my other email that I'd be happy
with all of the GPIO AC97reset logic being contained in
arch/powerpc/platforms/52xx which kind of makes the comment moot.  :-)

g.

> ---
>  arch/powerpc/include/asm/mpc52xx.h           |    2 +
>  arch/powerpc/platforms/52xx/mpc52xx_common.c |   61 ++++++++++++++++++++++++++
>  2 files changed, 63 insertions(+), 0 deletions(-)


More information about the Linuxppc-dev mailing list