[PATCH] KVM: PPC: elide struct thread_struct instances from stack

Alexander Graf agraf at suse.de
Tue Jun 1 19:19:17 EST 2010


On 01.06.2010, at 10:36, Andreas Schwab wrote:

> Paul Mackerras <paulus at samba.org> writes:
> 
>> I re-read the relevant part of the PowerPC architecture spec
>> yesterday, and it seems pretty clear that the FPSCR doesn't affect the
>> behaviour of lfs and stfs, and is not affected by them.  So in fact 4
>> out of the 7 instructions in each of those procedures are unnecessary
>> (and similarly for the cvt_fd/df used in the alignment fixup code).
> 
> I'd prefer to have this deferred to a separate patch.

I agree. Andreas' patch takes the current logic and moves it to be KVM contained, so we don't clutter the stack. The fact that the old code was inefficient is a separate story.

Avi / Marcelo, please apply the patch nevertheless.


Alex



More information about the Linuxppc-dev mailing list