[PATCH] powerpc: rename immap_86xx.h to fsl_guts.h, and add 85xx support
Peter Tyser
ptyser at xes-inc.com
Fri Jul 23 01:30:17 EST 2010
Hi Timur,
> +/**
> + * Global Utility Registers.
> + *
> + * Not all registers defined in this structure are available on all chips, so
> + * you are expected to know whether a given register actually exists on your
> + * chip before you access it.
> + *
> + * Also, some registers are similar on different chips but have slightly
> + * different names. In these cases, one name is chosen to avoid extraneous
> + * #ifdefs.
> + */
> +#ifdef CONFIG_PPC_85xx
> +struct ccsr_guts_85xx {
> +#else
> +struct ccsr_guts_86xx {
> +#endif
Is there a good reason to have 2 different names for the same structure
depending on the architecture? I'd think keeping a common "ccsr_guts"
name would get rid of the ifdefs above as well as in code that can be
used on both 85xx and 86xx processors down the road.
Best,
Peter
More information about the Linuxppc-dev
mailing list