Badness with the kernel version 2.6.35-rc1-git1 running on P6 box
David Miller
davem at davemloft.net
Mon Jul 19 07:51:20 EST 2010
From: Eric Dumazet <eric.dumazet at gmail.com>
Date: Fri, 16 Jul 2010 14:20:42 +0200
> Le vendredi 16 juillet 2010 à 11:56 +0200, Eric Dumazet a écrit :
>
>> [PATCH] ehea: ehea_get_stats() should use GFP_KERNEL
>>
>> ehea_get_stats() is called in process context and should use GFP_KERNEL
>> allocation instead of GFP_ATOMIC.
>>
>> Clearing stats at beginning of ehea_get_stats() is racy in case of
>> concurrent stat readers.
>>
>> get_stats() can also use netdev net_device_stats, instead of a private
>> copy.
>>
>> Reported-by: divya <dipraksh at linux.vnet.ibm.com>
>> Signed-off-by: Eric Dumazet <eric.dumazet at gmail.com>
>> ---
>> drivers/net/ehea/ehea.h | 1 -
>> drivers/net/ehea/ehea_main.c | 6 ++----
>> 2 files changed, 2 insertions(+), 5 deletions(-)
>>
>>
>
> Hmm, net-next-2.6 contains following patch :
If people think ehea usage is ubiquitous enough to deserve a backport
of this to net-2.6, fine. But personally I don't think it's worth it.
Can someone close the kernel bugzilla 16406 created for this bug? This
patch we have already obviously would fix this issue.
More information about the Linuxppc-dev
mailing list