[PATCH V4] powerpc/prom: Export device tree physical address via proc

Segher Boessenkool segher at kernel.crashing.org
Thu Jul 15 01:46:48 EST 2010


>> Any particular reason you fixed only one of the two
>> mispelings I pointed out?  (device tree is two words,
>> not one).
>
> Ahh, my fault.

Well I wasn't terribly clear ;-)

>> You could use one property instead of two; use addr+len
>> like every other property does.
>>
>> You also should use a better name for the property; is this
>> the previous kernel's device tree?  Just "device-tree" makes
>> no sense, it is not pointing to "the" device tree for sure!
>
> What about just one node called "flat-device-tree"?

But *what* flat device tree?  It cannot be "the" flat device tree,
or it would be useless information, since we are already reading it!


Segher



More information about the Linuxppc-dev mailing list