[rtc-linux] [PATCH v2] rtc: add support for DS3232 RTC
tiefei.zang at gmail.com
Mon Jul 12 19:05:01 EST 2010
On Mon, Jul 12, 2010 at 4:30 PM, Wan ZongShun <mcuos.com at gmail.com> wrote:
> 2010/7/12 Tiefei zang <tiefei.zang at gmail.com>:
>> On Mon, Jul 12, 2010 at 3:08 PM, Wan ZongShun <mcuos.com at gmail.com> wrote:
>>> 2010/7/12 Roy Zang <tie-fei.zang at freescale.com>:
>>>> This patch adds the driver for RTC chip DS3232 via I2C bus.
>>> I noted this patch is the second version, maybe you can describe which
>>> modifications you have done here.
>>> and add [PATCH v2] to mail subject.
>> I do not think the modification comparing previous version should go
>> into the commit message.
>> I buy in your comments in original version patch and update:
>> 1. add rtc_valid_tm to check return value.
>> 2. remove ioctl function, which do not used and tested.
>> 3. add __devinit for ds3232 probe
>> 4. put request irq after driver registration.
> Which git tree do you want to merge your patch?
I can see you add Andrew in the mail loop.
I think Andrew's test tree should be OK for this patch.
I just updated the patch. So if there is no problem, please pick up the v3:
More information about the Linuxppc-dev