[PATCH 3/8 v2] mtd: Add MPC5121 NAND Flash Controller driver

Wolfgang Denk wd at denx.de
Thu Jan 28 07:24:27 EST 2010


Dear Grant Likely,

In message <fa686aa41001270843u3b4e9687k699ad579de4460d4 at mail.gmail.com> you wrote:
>
> > +       if (rev != 2) {
> > +               dev_err(dev, "SoC revision %u is not supported!\n", rev);
> > +               return -ENXIO;
> > +       }
>
> *Only* revision 2?  Are future revisions of silicon assumed to be broken then?

I vote for keeping it this way - if you look at the diffferences
between revision 1 and 2, or at differences between MPC5121/3 and
MPC5125, it is more than likely that revision 3, should it ever come
out, will be incompatible and require driver changes.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Landru! Guide us!
	-- A Beta 3-oid, "The Return of the Archons", stardate 3157.4


More information about the Linuxppc-dev mailing list