[PATCH 01/11] fs_enet: Add support for MPC512x to fs_enet driver

Scott Wood scottwood at freescale.com
Thu Jan 21 04:02:42 EST 2010


Anatolij Gustschin wrote:
> Scott Wood <scottwood at freescale.com> wrote:
>> You can put a data pointer in the of_platform match struct, instead of 
>> re-checking the compatible.
> 
> .data pointer in 'fs_enet_mdio_fec_match' is already used for
> mpc5xxx_get_bus_frequency(). Setting .data to some sort of FEC ID in
> match struct for "fsl,pq1-fec-mdio" would be confusing to.

You could point .data to a struct if there are multiple things.

-Scott


More information about the Linuxppc-dev mailing list