[PATCH] ucc_geth: Fix full TX queue processing

David Miller davem at davemloft.net
Tue Jan 19 21:00:38 EST 2010


From: Anton Vorontsov <avorontsov at ru.mvista.com>
Date: Mon, 18 Jan 2010 18:47:50 +0300

> From: Jiajun Wu <b06378 at freescale.com>
> 
> commit 7583605b6d29f1f7f6fc505b883328089f3485ad ("ucc_geth: Fix empty
> TX queue processing") fixed empty TX queue mishandling, but didn't
> account another corner case: when TX queue becomes full.
> 
> Without this patch the driver will stop transmiting when TX queue
> becomes full since 'bd == ugeth->txBd[txQ]' actually checks for
> two things: queue empty or full.
> 
> Let's better check for NULL skb, which unambiguously signals an empty
> queue.
> 
> Signed-off-by: Jiajun Wu <b06378 at freescale.com>
> Signed-off-by: Anton Vorontsov <avorontsov at ru.mvista.com>

Applied.


More information about the Linuxppc-dev mailing list