[PATCH]: powerpc: Fix build breakage due to incorrect location of autoconf.h

[Joakim Tjernlund]

Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote on 13/01/2010 21:02:43:
>
> On Wed, 2010-01-13 at 12:54 -0600, Kumar Gala wrote:
>
> > >
> > > BOOTCFLAGS   += -I$(obj) -I$(srctree)/$(obj)
> > > -BOOTCFLAGS   += -include include/linux/autoconf.h -Iarch/powerpc/include
> > > -BOOTCFLAGS   += -Iinclude
> > > +BOOTCFLAGS   += -include include/generated/autoconf.h
> > > +BOOTCFLAGS   += -I$(srctree)/arch/powerpc/include -I$(srctree)/include
> > >
> > > DTS_FLAGS   ?= -p 1024
> > >
> >
> > Ack, this works for me (seeing as -rc4 doesn't generate uImages w/o it :)
> >
>
> I sent a different patch to Linus yesterday for that.

Seen it now as it is in Linus tree:

1) IMHO it would have been nicer to use #ifdef __KERNEL__
   instead of CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
   as then arches that don't define CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
   at all will never use the new optimization or was that what you intended?

2) You really should add an comment in the Makefile about not using
   autoconf.h/-D__KERNEL__