[PATCH 13/13] powerpc/5200: LocalPlus driver: clean up comments

[Grant Likely]

On Tue, Dec 22, 2009 at 12:13 AM, Roman Fietze
<roman.fietze at telemotive.de> wrote:
>
> Signed-off-by: Roman Fietze <roman.fietze at telemotive.de>

If this description is no longer correct, then you must also add
comments describing the new behaviour.

Thanks for all the work on this.  I hope I haven't been too brutal on
my comments, but this device is subtle and the driver supports lots of
different transfer modes so I'm being cautious.  It will help if you
can tighten up your patches to split apart unrelated changes and to
write proper patch descriptions.

I look forward to your respin.

Cheers,
g.

> ---
>  arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c |   14 --------------
>  1 files changed, 0 insertions(+), 14 deletions(-)
>
> diff --git a/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c b/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c
> index b2c92f5..a89072a 100644
> --- a/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c
> +++ b/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c
> @@ -206,17 +206,6 @@ static void mpc52xx_lpbfifo_kick(struct mpc52xx_lpbfifo_request *req)
>  /**
>  * mpc52xx_lpbfifo_sclpc_irq - IRQ handler for LPB FIFO
>  *
> - * On transmit, the dma completion irq triggers before the fifo
> - * completion triggers.  Handle the dma completion here instead of the
> - * LPB FIFO Bestcomm task completion irq because everything is not
> - * really done until the LPB FIFO completion irq triggers.
> - *
> - * In other words:
> - * For DMA, on receive, the "Fat Lady" is the bestcom completion irq. on
> - * transmit, the fifo completion irq is the "Fat Lady". The opera (or in
> - * this case the DMA/FIFO operation) is not finished until the "Fat
> - * Lady" sings.
> - *
>  * Reasons for entering this routine:
>  * 1) PIO mode rx and tx completion irq
>  * 2) DMA interrupt mode tx completion irq
> @@ -411,9 +400,6 @@ void mpc52xx_lpbfifo_poll(void)
>  {
>        struct mpc52xx_lpbfifo_request *req = lpbfifo.req;
>
> -       /*
> -        * For more information, see comments on the "Fat Lady"
> -        */
>        if (mpc52xx_lpbfifo_is_dma(req->flags) && (req->flags & MPC52XX_LPBFIFO_FLAG_WRITE))
>                mpc52xx_lpbfifo_sclpc_irq(0, NULL);
>        else
> --
> 1.6.5.5
>
>
>
> --
> Roman Fietze                Telemotive AG Büro Mühlhausen
> Breitwiesen                              73347 Mühlhausen
> Tel.: +49(0)7335/18493-45        http://www.telemotive.de
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.