[PATCH 1/2] pmac-zilog: add platform driver

[Geert Uytterhoeven]

On Tue, Nov 17, 2009 at 10:04, Finn Thain <fthain at telegraphics.com.au> wrote:
> Add platform driver to the pmac-zilog driver for mac 68k, putting the
> powermac-specific bits inside #ifdef CONFIG_PPC_PMAC.

> --- linux-2.6.31.orig/drivers/serial/pmac_zilog.c       2009-11-17 17:07:28.000000000 +1100
> +++ linux-2.6.31/drivers/serial/pmac_zilog.c    2009-11-17 17:07:38.000000000 +1100

> @@ -1427,6 +1439,8 @@ static struct uart_ops pmz_pops = {
>  #endif
>  };
>
> +#ifdef CONFIG_PPC_PMAC
> +
>  /*
>  * Setup one port structure after probing, HW is down at this point,
>  * Unlike sunzilog, we don't need to pre-init the spinlock as we don't
> @@ -1823,6 +1837,88 @@ next:
>        return 0;
>  }
>
> +#else
> +
> +extern struct platform_device scc_a_pdev, scc_b_pdev;

scripts/checkpatch.pl doesn't like this extern, and it's right.
Can't this be found using standard platform device/driver matching?

BTW, there are a few other minor checkpatch issues with some of the
other patches in the series,
too.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds