[async_tx-next PATCH 1/2] fsldma: Fix cookie issues
Ira W. Snyder
iws at ovro.caltech.edu
Fri Feb 26 06:21:59 EST 2010
On Mon, Feb 22, 2010 at 11:40:31AM -0600, Steven J. Magnani wrote:
> fsl_dma_tx_submit() only sets the cookie on the first descriptor of a
> transaction. It should set the cookie on all.
>
> Signed-off-by: Steven J. Magnani <steve at digidescorp.com>
> ---
> diff -uprN a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
> --- a/drivers/dma/fsldma.c 2010-02-22 11:16:36.000000000 -0600
> +++ b/drivers/dma/fsldma.c 2010-02-22 11:24:01.000000000 -0600
> @@ -362,7 +362,7 @@ static dma_cookie_t fsl_dma_tx_submit(st
> if (cookie < 0)
> cookie = 1;
>
> - desc->async_tx.cookie = cookie;
> + child->async_tx.cookie = cookie;
> }
>
> chan->common.cookie = cookie;
>
This looks correct to me. I'm not sure I ever tested the driver with a
chained struct dma_async_tx_descriptor.
Ira
More information about the Linuxppc-dev
mailing list