[PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

Grant Likely grant.likely at secretlab.ca
Thu Feb 11 01:14:26 EST 2010


On Wed, Feb 10, 2010 at 3:53 AM, Wolfgang Grandegger <wg at grandegger.com> wrote:
> Stephen Rothwell wrote:
>> Hi Wolfgang,
>>
>> On Wed, 10 Feb 2010 11:09:25 +0100 Wolfgang Grandegger <wg at grandegger.com> wrote:
>>>> __devinitdata goes at the end, immediately before the '='.  Ditto
>>>> throughout the file.
>>> This made a difference and revealed section mismatches. "const" seems to
>>> be incompatible with "__devinitdata".
>>
>> Maybe try no "const" and "__devinitconst" (I am not sure if both will
>> work).
>
> Yes, that works, even together with "const". To avoid rolling out the
> whole patch series again, I can prepare a follow-up patch fixing this issue.

Nah, just resend this one patch.

g.


More information about the Linuxppc-dev mailing list