powermac/low_i2c.c: three minor problems

d binderman dcb314 at hotmail.com
Sat Feb 6 23:13:29 EST 2010



Hello there,

I just ran the sourceforge tool cppcheck over the source code of the
new Linux kernel 2.6.33-rc6

It said

[./arch/powerpc/platforms/powermac/low_i2c.c:594]: (style) The scope of the variable chans can be reduced
[./arch/powerpc/platforms/powermac/low_i2c.c:594]: (style) The scope of the variable i can be reduced
[./arch/powerpc/platforms/powermac/low_i2c.c:1260]: (style) Redundant condition. It is safe to deallocate a NULL pointer

Please find attached a patch to fix these minor problems.  
The patched version compiles, but I have not been able to test it at run time.

Regards

David Binderman
 		 	   		  
_________________________________________________________________
Do you have a story that started on Hotmail? Tell us now
http://clk.atdmt.com/UKM/go/195013117/direct/01/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug30.patch
Type: text/x-patch
Size: 883 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20100206/26b9c091/attachment.bin>


More information about the Linuxppc-dev mailing list