[PATCH V6 00/10] Add-Synopsys-DesignWare-HS-USB-OTG-driver

[Neil Jones]

Hi,

We are currently using the latest version of this Synopsis IP in some
of our customers SoC's.

The latest hardware adds a new DMA mode which is less Interrupt
intensive as well as a few other features.

I have spent (and im still spending) a long time fixing up this driver
to be linux standards compliant with the intention of pushing it
upstream once complete, its still not ready yet.

One of the major issues we had is the driver isn't SMP safe, I've not
had chance to review your patches yet but have your run the driver
with lock checking turned on ?

Would it be possible to get the changes for the latest version of the
IP merged into this driver, I can supply my current version as a
reference.

In my driver :

Currently host support is working well and i've tested it with
multiple devices and done the test outlined on
http://www.linux-usb.org/usbtest/, the driver passed checkpatches and
runs with lockdeps on and on a SMP system, Im still working on the
device mode (PCD) part of the driver generally it works, but im still
getting the odd lock dep warning and a panic on un-loading of certain
gadget kernel modules. The only issue with our driver is I have not
converted all the bitfield usage to macros so it might make diffing a
pain.

Cheers

Neil

On Fri, Dec 10, 2010 at 10:44 PM, Greg KH <greg at kroah.com> wrote:
> On Wed, Dec 08, 2010 at 04:28:59PM -0800, tmarri at apm.com wrote:
>> From: Tirumala Marri <tmarri at apm.com>
>>
>> v6:
>>  1. Replaced register definitions and bit fields with macros.
>>  2. Replace printks with dev_dbg or dev_err functions.
>>  3. Cleanup some assignments.
>>  4. Remove chip specific selections in Kconfig file.
>
> There are still a lot of checkpatch errors and warnings in these
> patches.  Patch 1-8 has:
>        total: 64 errors, 126 warnings, 13905 lines checked
>
> Care to fix all of these up in your next submission?  I can't take these
> as-is, sorry.
>
> And, if you haven't run checkpatch.pl before, odds are you haven't run
> 'sparse'.  Please run that as well and resolve the issues it finds.
>
> thanks,
>
> greg k-h
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>