[PATCH -mm 4/4] RapidIO: Add new sysfs attributes

Bounine, Alexandre Alexandre.Bounine at idt.com
Sun Dec 12 05:49:33 EST 2010


Andrew Morton <akpm at linux-foundation.org> wrote:
> 
> One would like to see documentation updates along with sysfs API
> updates.  But one fears that this entire interface wasn't documented
> anyway :(

I think I have to find a time for that. I am adding it into my TODO
list.
 
> Please at least fully describe the proposed interface in the changelog
> so others can review the proposal.

Will do.
 
> The proposed new sysfs files appear to break the
> one-value-per-sysfs-file rule.

This is true for two of them. I was trying to find a better format for
them and at the end decided to break a rule and use port-device format
for this first version.
I may use just device name but "lnext" has to show multiple devices
anyway.
I decided the one-value-per-sysfs-file rule because it was broken once
already by the "routes" attribute (lprev and lnext have a similar
format).



More information about the Linuxppc-dev mailing list