[PATCH 5/9] RapidIO: Add default handler for error_stopped state
Bounine, Alexandre
Alexandre.Bounine at idt.com
Tue Aug 17 00:47:18 EST 2010
Micha Nelissen wrote:
>
> Alexandre Bounine wrote:
> > +
> > + if (err_status & RIO_PORT_N_ERR_STS_PW_OUT_ES) {
> > + pr_debug("RIO_EM: servicing Output Error-Stopped
state\n");
> > + /*
> > + * Send a Link-Request/Input-Status control symbol
> > + */
> > +
> > + /* Read from link maintenance response register
> > + * to clear valid bit */
> > + rio_mport_read_config_32(mport, destid, hopcount,
> > + rdev->phys_efptr + RIO_PORT_N_MNT_RSP_CSR(pnum),
> > + ®val);
> > + udelay(50);
>
> Perhaps this whole part of operating the MNT_RSP registers (sending
> link-request symbol is the only useful action IIRC?) can be put in a
> separate function for readability.
>
I was on the fence with this one. Now I have an extra vote in favor of a
separate function ;)
Will do.
More information about the Linuxppc-dev
mailing list