[PATCH 3/9] RapidIO: Add the ingress port number into the RIO switch data structure

Bounine, Alexandre Alexandre.Bounine at idt.com
Mon Aug 16 23:40:09 EST 2010


Micha Nelissen wrote:
> 
> Alexandre Bounine wrote:
> > A switch ingress port number has to be saved for software assisted
error
> > recovery from the error-stopped state. Saving this information also
allows
> > to remove several register reads from the RIO enumeration process.
> 
> Why not keep using the swpinfo field, as you can extract it from
there?
> And your code actually does this.
> 
> Also processor devices can have multiple ports (not only switches), it
> would be good to be ready for that use case.
> 
Agree. I missed the Multiport bit introduced in RIO spec 2.1. Now it is
justified to be as it was before.
I will rework this and next patches. 


More information about the Linuxppc-dev mailing list