[PATCH 1/3 v2] sdhci: Add auto CMD12 support for eSDHC driver

Zang Roy-R61911 r61911 at freescale.com
Tue Aug 10 20:07:20 EST 2010


 

> -----Original Message-----
> From: Michał Mirosław [mailto:mirqus at gmail.com] 
> Sent: Tuesday, August 10, 2010 2:25 AM
> To: Zang Roy-R61911
> Cc: linux-mmc at vger.kernel.org; linuxppc-dev at ozlabs.org; 
> akpm at linux-foundation.org
> Subject: Re: [PATCH 1/3 v2] sdhci: Add auto CMD12 support for 
> eSDHC driver
> 
> 2010/8/3 Roy Zang <tie-fei.zang at freescale.com>:
> [...]
> > @@ -240,6 +240,8 @@ struct sdhci_host {
> >  #define SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN              (1<<25)
> >  /* Controller cannot support End Attribute in NOP ADMA 
> descriptor */
> >  #define SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC              (1<<26)
> > +/* Controller uses Auto CMD12 command to stop the transfer */
> > +#define SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12             (1<<27)
> >
> >        int                     irq;            /* Device IRQ */
> >        void __iomem *          ioaddr;         /* Mapped address */
> 
> Just a cosmetic hint: I suggest SDHCI_QUIRK_MULTIBLOCK_READ_AUTO_CMD12
> or something for the quirk name, because ACMD12 part might be confused
> with MMC/SD App CMD 12 (CMD55+CMD12 combo) if/whenever that gets used.
Thanks for the suggestion.
There are several ACMD12 needed to be updated.
Send a new patch to update it.
Roy



More information about the Linuxppc-dev mailing list