[PATCH 3/3] powerpc-silence-xics_migrate_irqs_away-during-cpu-offline

Darren Hart dvhltc at us.ibm.com
Thu Aug 5 14:28:35 EST 2010


From: Signed-off-by: Darren Hart <dvhltc at us.ibm.com>

All IRQs are migrated away from a CPU that is being offlined so the
following messages suggest a problem when the system is behaving as
designed:

IRQ 262 affinity broken off cpu 1
IRQ 17 affinity broken off cpu 0
IRQ 18 affinity broken off cpu 0
IRQ 19 affinity broken off cpu 0
IRQ 256 affinity broken off cpu 0
IRQ 261 affinity broken off cpu 0
IRQ 262 affinity broken off cpu 0

Don't print these messages when the CPU is not online.

Signed-off-by: Darren Hart <dvhltc at us.ibm.com>
Acked-by: Will Schmidt <will_schmidt at vnet.ibm.com>
Cc: Thomas Gleixner <tglx at linutronix.de>
Cc: Nathan Fontenot <nfont at austin.ibm.com>
Cc: Robert Jennings <rcj at linux.vnet.ibm.com>
Cc: Brian King <brking at linux.vnet.ibm.com>
---
 arch/powerpc/platforms/pseries/xics.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/platforms/pseries/xics.c b/arch/powerpc/platforms/pseries/xics.c
index f19d194..8d0b0b1 100644
--- a/arch/powerpc/platforms/pseries/xics.c
+++ b/arch/powerpc/platforms/pseries/xics.c
@@ -930,8 +930,10 @@ void xics_migrate_irqs_away(void)
 		if (xics_status[0] != hw_cpu)
 			goto unlock;
 
-		printk(KERN_WARNING "IRQ %u affinity broken off cpu %u\n",
-		       virq, cpu);
+		/* This is expected during cpu offline. */
+		if (cpu_online(cpu))
+			printk(KERN_WARNING "IRQ %u affinity broken off cpu %u\n",
+			       virq, cpu);
 
 		/* Reset affinity to all cpus */
 		cpumask_setall(irq_to_desc(virq)->affinity);
-- 
1.7.0.4



More information about the Linuxppc-dev mailing list