[PATCH 1/4] fsl_msi: fix the conflict of virt_msir's chip_data

Kumar Gala galak at kernel.crashing.org
Mon Apr 19 22:19:25 EST 2010


On Apr 18, 2010, at 11:50 PM, Li Yang wrote:

> On 4/19/2010 10:40 AM, Michael Ellerman wrote:
>> On Fri, 2010-04-16 at 15:34 +0800, Li Yang wrote:
>>   
>>> From: Zhao Chenhui<b26998 at freescale.com>
>>> 
>>> In fsl_of_msi_probe(), the virt_msir's chip_data have been stored
>>> the pointer to struct mpic. We add a struct fsl_msi_cascade_data
>>> to store the pointer to struct fsl_msi and msir_index.  Otherwise,
>>> the pointer to struct mpic will be over-written, and will cause
>>> problem when calling eoi() of the irq.
>>>     
>> I don't quite understand. Do you mean someone was overwriting
>> handler_data somewhere?
>>   
> 
> The patch at http://patchwork.ozlabs.org/patch/48794/ was overwriting the chip_data.  We move the newly added pointer to fsl_msi structure to the handler data.

Let's fix that patch.

- k


More information about the Linuxppc-dev mailing list