[PATCH] mpc5200: support for the MAN mpc5200 based board mucmc52

Grant Likely grant.likely at secretlab.ca
Tue Sep 15 00:45:57 EST 2009


On Mon, Sep 14, 2009 at 2:03 AM, Wolfram Sang <w.sang at pengutronix.de> wrote:
> Hi,
>
>> +             mpc5200_pic: interrupt-controller at 500 {
>> +                     // 5200 interrupts are encoded into two levels;
>
> Grant, maybe this comment could be dropped also for the in-kernel dts-files? I
> think it is sufficently described in mpc5200.txt. I could prepare a patch if
> you agree.

Meh.  I don't mind it being there.  Interrupt encoding is confusing
enough as is for people unfamiliar with the device tree, that any
additional hints are a plus.  In fact, if you want to prepare a patch,
instead of removing this comment, replace it with one that tells
readers where to look for the encoding documentation.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.


More information about the Linuxppc-dev mailing list